Skip VC Merge Module fatal error when JASP_SYNTAX_INTERFACE_ONLY=ON - #6222
Open
boutinb wants to merge 1 commit into
Open
Skip VC Merge Module fatal error when JASP_SYNTAX_INTERFACE_ONLY=ON#6222boutinb wants to merge 1 commit into
boutinb wants to merge 1 commit into
Conversation
The merge module is only needed for the Windows installer, not for building SyntaxInterface.dll. Downgrade FATAL_ERROR to WARNING so the jaspSyntax CI can configure without requiring the redistributable MSMs. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JASP_SYNTAX_INTERFACE_ONLY=ON, downgrade the missing VC Merge Module from aFATAL_ERRORto aWARNING.The Merge Module (
Microsoft_VC143_CRT_x64.msm) is only needed by the Windows installer (CPack). BuildingSyntaxInterface.dllin CI (via thejaspSyntaxworkflow) does not require it, so the unconditionalFATAL_ERRORprevents the CI build from completing.The
JASP_SYNTAX_INTERFACE_ONLYoption was introduced in #6219. This PR adds the matching guard to the Merge Module check.Test plan
build-syntaxinterfaceworkflow completes the CMake configure step without the VC Merge Module fatal error when-DJASP_SYNTAX_INTERFACE_ONLY=ONis passed.JASP_SYNTAX_INTERFACE_ONLY=OFF).🤖 Generated with Claude Code